Skip to content

Conversation

@AndreiKingsley
Copy link
Collaborator

Kandy dependcies updates from #1584

@AndreiKingsley AndreiKingsley marked this pull request as ready for review November 28, 2025 15:30
# Example notebooks Kandy versions
kandy-notebook = "0.8.1n"
kandy-stats-notebook = "0.5.0n"
kandy = "0.8.3-dev-92"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, we only use kandy in notebooks? so only the -n version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, kandy doesn't have a "-n" version now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that works fine? Does it include DataFrame as compileOnly() now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine both in gradle and notebooks, but you need to add dataframe dependency first.
And no, DataFrame is included as implementation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need to ask user to %use dataframe before kandy!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding something like this to our jupyter integration?

onLoaded {
    val alreadyLoadedKandy = try {
        execute("kandyConfig").value
        true
    } catch (_: Exception) {
        false
    }

    if (alreadyLoadedKandy) {
        display(
            "Kandy was found on the notebook classpath. When combined with DataFrame, make sure DataFrame is loaded first; then Kandy.",
            null,
        )
    }
}

I think something like that could prevent some confusion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants